Google Cloud Pub/Sub: require JSON responses #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
reviewed
Mar 18, 2020
| @@ -164,7 +164,7 @@ private[pubsub] trait PubSubApi { | |||
| .mapAsync(1) { | |||
| case Success(response) => | |||
| response.status match { | |||
| case StatusCodes.Success(_) => | |||
| case StatusCodes.Success(_) if response.entity.contentType == ContentTypes.`application/json` => | |||
There was a problem hiding this comment.
Maybe also include the contentType in the "Unexpected response" exception below, to help debugging when the response is rejected because the content-type is wrong?
raboof
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guard the HTTP response to be JSON before trying to deserialize it so that missing subscriptions aren't reported as marshalling problems.
References #1840