Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flicker test in Kinesis KCL #2229

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Fix flicker test in Kinesis KCL #2229

merged 2 commits into from
Mar 25, 2020

Conversation

aserrallerios
Copy link
Contributor

Fixes (or tries to) #2219

I cannot reproduce the error locally, can you try it @seglo ?

@seglo seglo self-assigned this Mar 25, 2020
@seglo seglo self-requested a review March 25, 2020 18:38
seglo
seglo approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for the quick turn around.

[info] All tests passed.
[info] Passed: Total 1000, Failed 0, Errors 0, Passed 1000

@aserrallerios
Copy link
Contributor Author

Sorry for my ignorance, but why not use org.scalatest.Retries?

@seglo
Copy link
Member

seglo commented Mar 25, 2020

Sorry for my ignorance, but why not use org.scalatest.Retries?

I use the Repeated trait to force many test runs to identify and fix transiently failing tests. AFAIK there's nothing available in ScalaTest that can do that. Retries is to retry a test if it fails, with some rules.

@seglo seglo merged commit 2cd0c00 into akka:master Mar 25, 2020
@seglo seglo mentioned this pull request Mar 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seglo seglo seglo approved these changes

Assignees

@seglo seglo

Labels
p:kinesis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aserrallerios @seglo