Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MQTT: avoid completing promise on reconnect #2289

Merged
merged 1 commit into from
Apr 28, 2020
Merged

MQTT: avoid completing promise on reconnect #2289

merged 1 commit into from
Apr 28, 2020

Conversation

ennru
Copy link
Member

@ennru ennru commented Apr 28, 2020

The materialized subscription promise should not be completed again when a reconnect happens.

(I'm not sure yet why this problem didn't show earlier.)

References #2288

@ennru ennru added this to the 2.0.0 milestone Apr 28, 2020
@ennru
Copy link
Member Author

ennru commented Apr 28, 2020

The behaviour changed with the upgrade of the Paho client library in #2236

@ennru ennru requested a review from seglo April 28, 2020 12:40
@ennru ennru mentioned this pull request Apr 28, 2020
Merged
seglo
seglo approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seglo seglo merged commit 76f9d94 into akka:master Apr 28, 2020
@seglo seglo mentioned this pull request Apr 28, 2020
Closed
@ennru ennru deleted the mqtt-reconnect branch April 28, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seglo seglo seglo approved these changes

Assignees
No one assigned
Labels
p:mqtt
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ennru @seglo