Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kinesis: code layout #2300

Merged
merged 2 commits into from
May 7, 2020
Merged

Kinesis: code layout #2300

merged 2 commits into from
May 7, 2020

Conversation

YikSanChan
Copy link
Contributor

@YikSanChan YikSanChan commented May 2, 2020 •
edited
Loading

Group override def together for better readability

@YikSanChan YikSanChan force-pushed the yiksanchan/having-ShardRecordProcessor-method-stay-together branch from b611182 to 6e23302 Compare May 2, 2020 03:04
@YikSanChan
Copy link
Contributor Author

@aserrallerios Do you mind reviewing this? Thanks!

@YikSanChan
Copy link
Contributor Author

@ennru Got Albert's approval, do you mind taking a look?

ennru
ennru approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Needs a rebase.

@ennru ennru added this to the 2.0.1 milestone May 7, 2020
@YikSanChan
Have ShardRecordProcessor methods stay together
503ee62 
For slightly better readability
@YikSanChan YikSanChan force-pushed the yiksanchan/having-ShardRecordProcessor-method-stay-together branch from 6e23302 to 503ee62 Compare May 7, 2020 20:03
@YikSanChan
Copy link
Contributor Author

@ennru Resolved

@ennru ennru changed the title Have ShardRecordProcessor methods stay together Kinesis: code layout May 7, 2020
@ennru ennru merged commit fefc985 into akka:master May 7, 2020
@ennru
Copy link
Member

ennru commented May 7, 2020

Thank you for all your suggestions to improve the code in tiny steps. Very appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aserrallerios aserrallerios aserrallerios approved these changes

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
p:kinesis
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@YikSanChan @ennru @aserrallerios