Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cassandra: Driver 4.6.1 (Remove netty override) #2320

Merged
merged 2 commits into from
Jun 4, 2020
Merged

Cassandra: Driver 4.6.1 (Remove netty override) #2320

merged 2 commits into from
Jun 4, 2020

Conversation

chbatey
Copy link
Member

@chbatey chbatey commented May 19, 2020

Underlying perf issue has been fixed

@chbatey
Remove netty override for cassandra driver
c446ae4 
Underlying perf issue has been fixed
@probot-autolabeler probot-autolabeler bot added the dependency-change For PRs changing the version of a dependency. label May 19, 2020
@chbatey chbatey mentioned this pull request May 19, 2020
Closed
raboof
raboof approved these changes May 19, 2020
View reviewed changes
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Underlying perf issue has been fixed

\o/

@ennru
Copy link
Member

ennru commented May 26, 2020

@chbatey What do we know about bin-compatibility between Cassandra 4.5 and 4.6?
Should we consider this change for a patch version?

@chbatey
Copy link
Member Author

chbatey commented Jun 4, 2020

Only major version break binary compatibility AFAIK

@ennru
Copy link
Member

ennru commented Jun 4, 2020

Fixes #2226

ennru
ennru approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru changed the title Remove netty override for cassandra driver Cassandra: Driver 4.6.1 (Remove netty override) Jun 4, 2020
@ennru ennru merged commit c5d2e46 into akka:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

@raboof raboof raboof approved these changes

Assignees
No one assigned
Labels
dependency-change For PRs changing the version of a dependency. p:cassandra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chbatey @ennru @raboof