Google FCM: Forward proxy #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @atyutin90, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
atyutin90
force-pushed
the
google_fcm_proxy
branch
4 times, most recently
from
e63eed8
to
b1df19a
Compare
atyutin90
force-pushed
the
google_fcm_proxy
branch
from
b1df19a
to
3af23c0
Compare
atyutin90
force-pushed
the
google_fcm_proxy
branch
from
3af23c0
to
8809974
Compare
ennru
approved these changes
Oct 23, 2020
| import akka.http.scaladsl.model.headers.BasicHttpCredentials | ||
| import akka.http.scaladsl.settings.{ClientConnectionSettings, ConnectionPoolSettings} | ||
|
|
||
| private[fcm] object ForwardProxyPoolSettings { |
|
Thank you for applying this to Google FCM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Akka HTTP has support for forward proxies via its Pluggable Client Transports. The functionality is used in this update in order to support forward proxies when integrating with Google FCM.
References
Changes
Background Context