Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamoDb: Akka 2.6 #2544

Merged
merged 2 commits into from
Dec 15, 2020
Merged

DynamoDb: Akka 2.6 #2544

merged 2 commits into from
Dec 15, 2020

Conversation

ennru
Copy link
Member

@ennru ennru commented Dec 11, 2020

References #2471

Copy link
Member

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A few minor things.

import akka.stream.Materializer

import scala.annotation.implicitNotFound
//import akka.stream.Materializer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@@ -76,8 +79,13 @@ object DynamoDb {
/**
* Create a Future that will be completed with a response to a given request.
*/
@implicitNotFound(
"an actor system (classic or new API) is a `ClassicActorSystemProvider`, provide that instead of a `Materializer`"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rephrase this a little?

Suggested change
"an actor system (classic or new API) is a `ClassicActorSystemProvider`, provide that instead of a `Materializer`"
"a `ClassicActorSystemProvider` is a classic or new API actor system, provide this instead of a `Materializer`"

@ennru ennru merged commit 0295b4a into akka:master Dec 15, 2020
@ennru ennru mentioned this pull request Dec 15, 2020
6 tasks
@seglo seglo added this to the 3.0.0-M1 milestone Feb 10, 2021
@ennru ennru deleted the akka-2.6-dynamodb branch April 21, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants