Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 - mat to system param typo #2616

Merged
merged 3 commits into from
May 12, 2021
Merged

S3 - mat to system param typo #2616

merged 3 commits into from
May 12, 2021

Conversation

seglo
Copy link
Member

@seglo seglo commented Mar 15, 2021

A continuation of #2513, #2494

I noticed all the Scala DSL usages of Materializer remained without an ActorSystem overload. It's not possible to add the overload without conflicts, so I made a breaking change instead.

i.e.

[error] both method deleteBucket in object S3 of type (bucketName: String, s3Headers: akka.stream.alpakka.s3.S3Headers)(implicit mat: akka.stream.Materializer, implicit attributes: akka.stream.Attributes)scala.concurrent.Future[akka.Done]
[error] and  method deleteBucket in object S3 of type (bucketName: String, s3Headers: akka.stream.alpakka.s3.S3Headers)(implicit system: akka.actor.ClassicActorSystemProvider, implicit attributes: akka.stream.Attributes)scala.concurrent.Future[akka.Done]
[error] match argument types (String,akka.stream.alpakka.s3.S3Headers) and expected result type scala.concurrent.Future[akka.Done]
[error]     deleteBucket(bucketName, S3Headers.empty)
                        

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@seglo seglo changed the title S3, drop materializer use in scaladsl S3 - mat to system param typo May 12, 2021
@seglo
Copy link
Member Author

seglo commented May 12, 2021

Mostly resolved in #2626. This just fixes a typo.

@seglo seglo added this to the 3.0.0 milestone May 12, 2021
@seglo seglo merged commit 5c66bf0 into akka:master May 12, 2021
@seglo seglo deleted the seglo/s3-akka-26 branch May 12, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants