Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV: Support \r\r\n line endings #987

Closed
raskam opened this issue May 30, 2018 · 1 comment
Closed

CSV: Support \r\r\n line endings #987

raskam opened this issue May 30, 2018 · 1 comment
Labels
enhancement p:csv
Milestone
1.0-M2

Comments

@raskam
Copy link

raskam commented May 30, 2018 •
edited
Loading

Some CSV files generated by MS Dynamics / MS SQL contain \r\r\n newlines.

Right now we are transforming \r\r\n -> \r\n in the input before passing it to the CsvParsingStage. However, it should be pretty easy to support this format by modifying CsvParser FSM (adding a CR->AfterCr transition in the AfterCr state).

Does it make sense to support this non-standard format? If so, I could submit a PR.
@2m
Copy link
Member

2m commented May 31, 2018

I think this does make sense according to "be flexible in what you accept and strict in what you produce" :)

@ennru ennru mentioned this issue Dec 21, 2018
Merged
@2m 2m closed this as completed in #1398 Dec 31, 2018
@2m 2m added this to the 1.0-M2 milestone Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement p:csv
Projects
None yet
Milestone
1.0-M2
Development

No branches or pull requests
2 participants
@2m @raskam