Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solr for Alpakka 1.0 #1491

Merged
merged 14 commits into from
Feb 14, 2019
Merged

Solr for Alpakka 1.0 #1491

merged 14 commits into from
Feb 14, 2019

Conversation

ennru
Copy link
Member

@ennru ennru commented Feb 13, 2019

Fixes

Fixes #1307, #1090, #964

Purpose

Apply the desired code layout to the Solr connector.

  • Writing accepts only collection types java.util.List<WriteMessage<T, PT>> and scala.collection.immutable.Seq[WriteMessage[T, PT]] (was mutable.Seq before)
  • Rename IncomingMessage to WriteMessage with the same style of factory methods as for Elasticsearch (the somewhat non-standard factories in IncomingUpsertMessage are still there to ease migration)
  • Rename OutgoingMessage to WriteResult
  • Committing to Solr is now documented (and shown in the examples)

@2m
Copy link
Member

2m commented Feb 14, 2019

Unrelated failure was #1377

2m
2m approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@2m 2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@2m 2m merged commit cec1d54 into akka:master Feb 14, 2019
@ennru ennru deleted the solr-1.0 branch February 14, 2019 13:44
@ennru ennru mentioned this pull request Nov 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2m 2m 2m approved these changes

Assignees
No one assigned
Labels
api-change p:solr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ennru @2m