Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed: SolrTest.solrInputDocumentStream #1307

Closed
2m opened this issue Nov 6, 2018 · 0 comments
Closed

Failed: SolrTest.solrInputDocumentStream #1307

2m opened this issue Nov 6, 2018 · 0 comments
Labels
failed p:solr
Milestone
1.0-M3

Comments

@2m
Copy link
Member

2m commented Nov 6, 2018 

[error] Test akka.stream.alpakka.solr.SolrTest.solrInputDocumentStream failed: java.lang.AssertionError: expected:<[Akka Concurrency, Akka in Action, Effective Akka, Learning Scala, Programming in Scala, Scala Puzzlers, Scala for Spark in Production]> but was:<[Akka Concurrency, Akka in Action, Effective Akka, Learning Scala, Programming in Scala]>, took 2.831 sec
[error]     at akka.stream.alpakka.solr.SolrTest.solrInputDocumentStream(SolrTest.java:133)
[error]     ...
[debug] Test akka.stream.alpakka.solr.SolrTest.solrInputDocumentStream finished, took 2.833 sec

#1306
@2m 2m mentioned this issue Nov 6, 2018
Merged
@ennru ennru mentioned this issue Feb 13, 2019
Merged
@2m 2m closed this as completed in #1491 Feb 14, 2019
2m pushed a commit that referenced this issue Feb 14, 2019
@ennru @2m
Solr for Alpakka 1.0 (#1491)
cec1d54 
## Fixes

Fixes #1307, #1090, #964

## Purpose

Apply the desired code layout to the Solr connector.

* Writing accepts only collection types `java.util.List<WriteMessage<T, PT>>` and `scala.collection.immutable.Seq[WriteMessage[T, PT]]` (was `mutable.Seq` before) 
* Rename `IncomingMessage` to `WriteMessage` with the same style of factory methods as for Elasticsearch (the somewhat non-standard factories in `IncomingUpsertMessage` are still there to ease migration)
* Rename `OutgoingMessage` to `WriteResult`
* Committing to Solr is now documented (and shown in the examples)
@2m 2m added this to the 1.0-M3 milestone Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
failed p:solr
Projects
None yet
Milestone
1.0-M3
Development

No branches or pull requests
1 participant
@2m