Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apache Solr: become Alpakka 1.0 ready #1090

Closed
4 tasks done
ennru opened this issue Jul 4, 2018 · 0 comments
Closed
4 tasks done

Apache Solr: become Alpakka 1.0 ready #1090

ennru opened this issue Jul 4, 2018 · 0 comments
Labels
api-change p:solr
Milestone
1.0-M3

Comments

@ennru
Copy link
Member

ennru commented Jul 4, 2018 •
edited
Loading

  • Move internal code to impl package
  • Mark internal code @InternalApi and private[connector]
  • Move documentation example code to packages docs.javadsl and docs.scaladsl
  • Make settings to be non-case classes
@ennru ennru added the p:solr label Jul 4, 2018
@ennru ennru mentioned this issue Feb 13, 2019
Merged
2m pushed a commit that referenced this issue Feb 14, 2019
@ennru @2m
Solr for Alpakka 1.0 (#1491)
cec1d54 
## Fixes

Fixes #1307, #1090, #964

## Purpose

Apply the desired code layout to the Solr connector.

* Writing accepts only collection types `java.util.List<WriteMessage<T, PT>>` and `scala.collection.immutable.Seq[WriteMessage[T, PT]]` (was `mutable.Seq` before) 
* Rename `IncomingMessage` to `WriteMessage` with the same style of factory methods as for Elasticsearch (the somewhat non-standard factories in `IncomingUpsertMessage` are still there to ease migration)
* Rename `OutgoingMessage` to `WriteResult`
* Committing to Solr is now documented (and shown in the examples)
@2m 2m added this to the 1.0-M3 milestone Feb 14, 2019
@2m 2m closed this as completed Feb 14, 2019
@2m 2m added the api-change label Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api-change p:solr
Projects
None yet
Milestone
1.0-M3
Development

No branches or pull requests
2 participants
@2m @ennru