FTP: enable Scala 2.13 and 2.12.9 compilation #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
the
dependency-change
ennru
changed the title
2m
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Allow publishing Alpakka FTP for Scala 2.13, and using Scala 2.12.9 for compilation.
References
Issue #1532
Background Context
Using Scala 2.12.8 hits scala/bug#11305
Scala 2.13.0 does not compile the Java tests successfully which looks like the same problem of missing type signatures.
Changes
Due to the changed handling of static forwarders in Scala 2.12.8+ the pattern used to implement the different FTP styles doesn't compile anymore.
FtpApijust an interfaceFtpApi