Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpaka 1.1.x: Revert to Scala 2.12.7 (for FTP) #1971

Merged
merged 2 commits into from
Oct 7, 2019

Conversation

ennru
Copy link
Member

@ennru ennru commented Oct 4, 2019

Purpose

Alpakka FTP in the 1.1.x series can't be compiled with Scala >2.12.7 for some static forwarder issues.

References

Fixed for 2.0 in master by #1779

@ennru ennru added the p:ftp label Oct 4, 2019
@ennru ennru added this to the 1.1.2 milestone Oct 4, 2019
@probot-autolabeler probot-autolabeler bot added the dependency-change For PRs changing the version of a dependency. label Oct 4, 2019
@seglo
Copy link
Member

seglo commented Oct 4, 2019

There's a problem resolving silencer-* libs for Scala 2.12.

https://travis-ci.com/akka/alpakka/jobs/242133152#L634

I tried playing around with it locally to make it happy. I tried using version 1.4.4, but it can't find the exact Scala cross-compiled jar. I guess that has something to do with the fact that it's looking for a "full" cross-compiled match? I'll leave it to you since you have more experience with it.

compilerPlugin("com.github.ghik" % "silencer-plugin" % Version cross CrossVersion.full),

@seglo
Copy link
Member

seglo commented Oct 7, 2019

Failing test: https://travis-ci.com/akka/alpakka/jobs/242975205#L581

It's been observed before: #1801

@seglo seglo self-requested a review October 7, 2019 20:19
Copy link
Member

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seglo seglo merged commit 6b0ca18 into akka:release-1.1 Oct 7, 2019
@ennru ennru deleted the revert-scala-to-2.12.7 branch October 8, 2019 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency-change For PRs changing the version of a dependency. p:ftp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants