Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WithRemoting should only override declared values #108

Merged
merged 1 commit into from
Sep 16, 2022
Merged

WithRemoting should only override declared values #108

merged 1 commit into from
Sep 16, 2022

Conversation

Arkatufus
Copy link
Contributor

Make WithRemoting write the minimum HOCON override possible to prevent unexpected overrides of previously declared HOCON overrides

@Arkatufus Arkatufus changed the title WithRemoting should only override declared configurations WithRemoting should only override declared values Sep 15, 2022
Aaronontheweb
Aaronontheweb approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit cf7c95d into akkadotnet:dev Sep 16, 2022
@Aaronontheweb Aaronontheweb mentioned this pull request Sep 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
akka-remote
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkatufus @Aaronontheweb