Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port all modules from the JVM #1

Open
1 of 4 tasks
marcpiechura opened this issue Nov 13, 2016 · 17 comments
Open
1 of 4 tasks

Port all modules from the JVM #1

marcpiechura opened this issue Nov 13, 2016 · 17 comments

Comments

@marcpiechura
Copy link
Contributor

If possible we should port all available modules from the JVM.

  • AMQP
  • Cassandra
  • File
  • MQTT
@alexvaluyskiy
Copy link
Contributor

Why should we port all available modules from JVM? .NET world is too different from Java world

@SeanFarrow
Copy link
Contributor

I'm happy to port the sqs/sns module as I'll be needing this in a project. would a pr be accepted?

@marcpiechura
Copy link
Contributor Author

@SeanFarrow Sure !

@SeanFarrow
Copy link
Contributor

SeanFarrow commented Jun 1, 2017 via email

@marcpiechura
Copy link
Contributor Author

@SeanFarrow I would say stay as close as possible to the jvm version, but if some things don't make sense in .net or need to be handled differently feel free to make those changes.

Regarding mocking, take what you like, we don't use mocking inside the core repo so we don't have a preference.

@SeanFarrow
Copy link
Contributor

SeanFarrow commented Jun 1, 2017 via email

@marcpiechura
Copy link
Contributor Author

Is it possible to have a local instance you can use? If not, just port the tests, try it with some evaluation account and push it without automated tests.

@SeanFarrow
Copy link
Contributor

SeanFarrow commented Jun 1, 2017 via email

@marcpiechura
Copy link
Contributor Author

If it's to complicated, no worries, those connectors don't have the same "guarantees" as the core repo (see also the readme) and therefore don't neccarrily need a proper CI infrastructure.

@SeanFarrow
Copy link
Contributor

SeanFarrow commented Jun 1, 2017 via email

@marcpiechura
Copy link
Contributor Author

Sounds good!

@SeanFarrow
Copy link
Contributor

SeanFarrow commented Jun 2, 2017 via email

@marcpiechura
Copy link
Contributor Author

marcpiechura commented Jun 2, 2017

Task.Wait(TimeSpan.FromSeconds(1)).Should().BeTrue();
Task.Result.Should().BeEquivalentTo(publishResult);

Maybe the gitter room would be a better place for those questions ;-)

@SeanFarrow
Copy link
Contributor

Just a thought, should we add some CI around this repo?
Given that we have tests, it would be good if we were able ot run things like akka.net does on pr's.

@Arkatufus
Copy link
Contributor

There's a plan to set CI for Akka.net contrib, which is where this project will be moved, eventually.
Right now we're a bit busy maintaining 1.2.3 and preparing for 1.3.0

@SeanFarrow
Copy link
Contributor

SeanFarrow commented Jul 8, 2017 via email

@SeanFarrow
Copy link
Contributor

I've just been looking at this again and noticed the .net version of the sns code uses a string and the jvm version uses a PublishRequest. Should we change this?

By not using a PublishRequest, you lose the ability to provide metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants