Added missing FromConfig.Props(props) #1667
Conversation
skotzko
changed the title
|
@rogeralsing looks good to me, but you need to follow this process and update the PR to get the API approval specs to pass: http://getakka.net/docs/akka-developers/public-api-changes |
|
Something seems bonkers with the API approval stuff, it is merged and still fails |
|
According to @Silv3rcircl3 there is an localization issue in the API approval app that mixes up |
| @@ -3769,7 +3769,7 @@ namespace Akka.Routing | |||
| } | |||
| public class DefaultResizer : Akka.Routing.Resizer, System.IEquatable<Akka.Routing.DefaultResizer> | |||
| { | |||
| public DefaultResizer(int lower, int upper, int pressureThreshold = 1, double rampupRate = 0.2, double backoffThreshold = 0.3, double backoffRate = 0.1, int messagesPerResize = 10) { } | |||
| public DefaultResizer(int lower, int upper, int pressureThreshold = 1, double rampupRate = 0,2, double backoffThreshold = 0,3, double backoffRate = 0,1, int messagesPerResize = 10) { } | |||
There was a problem hiding this comment.
ouch it modifies the code to non valid C#....
There was a problem hiding this comment.
Running with UK settings now :-)
|
F# this.. : (╯°□°）╯︵ ┻━┻ I cant get the API approval stuff to work |
…cala API. ```csharp var router1 = ActorOf(FromConfig.Props(Props.Create<Worker>())) ``` Scala counterpart: ```scala val router1: ActorRef = context.actorOf(FromConfig.props(Props[Worker]), "router1") ``` Also cleaned up the RouterConfig.cs file to comply with C#6 language features. As all RouterConfig classes uses surrogates for serialization, no such language features affect the serializability of the types. api approved api
|
Problem with the diff software or which part? |
|
Its the API diff software that doesnt handle localization, many non US/UK devs will see a broken approved.txt I'm running with UK settings to produce proper API approvals ATM. |
|
Bah, sorry- is it an issue with:
We'll need to hard code a localization setting into one of those. I suspect the latter |
|
On mobile at the moment so my comments might sound a bit off - damn autocorrect |
Added missing FromConfig.Props(props)
Added missing convenience method to
FromConfigto comply with the Scala API.Scala counterpart:
All other router configs do have the corresponding Props method, so it makes sense to be consistent with Scala and the rest of the .NET router configs IMO, even if it is just slight sugar of the existing API.
Also cleaned up the RouterConfig.cs file to comply with C#6 language features.
As all RouterConfig classes uses surrogates for serialization, no such language features affect the serializability of the types.