Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use .NET Standard 2.0 and later as only build target #3944

Merged
merged 12 commits into from
Dec 21, 2019

Conversation

Aaronontheweb
Copy link
Member

@Aaronontheweb Aaronontheweb commented Oct 1, 2019

close #3851 - dropping .NET Framework 4.5.2 support.

Draft PR because we need to get rid of the old Helios transport package first.

@Aaronontheweb
Copy link
Member Author

#3945 needs to be merged into dev first before this can run successfully.

@Aaronontheweb Aaronontheweb marked this pull request as ready for review October 1, 2019 17:53
@Aaronontheweb
Copy link
Member Author

Aaronontheweb commented Oct 2, 2019

Welp, here's where this build hit the wall:

https://github.com/akkadotnet/akka.net/blob/0a8c0390ee24927e3c381a99bca079ebc7e5b8e9/src/core/Akka/Configuration/Hocon/AkkaConfigurationSection.cs

... @Arkatufus - so what should we do with this given that we're moving HOCON as a stand-alone feature into Akka.NET? If we get rid of AkkaConfigurationSection?

@Aaronontheweb
Copy link
Member Author

I think what we're going to end up doing here, so as to not introduce too many behavior changes at once, is wait and see how the new stand-alone HOCON integration goes and see if that library can offer a good solution.

@Arkatufus
Copy link
Contributor

Welp, here's where this build hit the wall:

https://github.com/akkadotnet/akka.net/blob/0a8c0390ee24927e3c381a99bca079ebc7e5b8e9/src/core/Akka/Configuration/Hocon/AkkaConfigurationSection.cs

... @Arkatufus - so what should we do with this given that we're moving HOCON as a stand-alone feature into Akka.NET? If we get rid of AkkaConfigurationSection?

This should fix it: Arkatufus@3e08c21

@Arkatufus
Copy link
Contributor

We should mark the old System.Configuration implementation as deprecated to prepare for standalone HOCON integration.

@Aaronontheweb
Copy link
Member Author

We should mark the old System.Configuration implementation as deprecated to prepare for standalone HOCON integration.

Have some API ideas for how we can do this...

@Aaronontheweb
Copy link
Member Author

@Arkatufus retrying this PR with your fix

@Aaronontheweb
Copy link
Member Author

Looks like that created some compilation problems on Linux - the same ValueTuple stuff we ran into in some other projects. System.Configuration.ConfigurationManager might take a dependency on something that references a different version of this same library.

@Aaronontheweb
Copy link
Member Author

Looks like we're good to go here. Going to merge this in and set the groundwork for stand-alone HOCON.

@Aaronontheweb Aaronontheweb merged commit 8481623 into akkadotnet:dev Dec 21, 2019
@Aaronontheweb Aaronontheweb deleted the fix-3851-drop-NET452 branch December 21, 2019 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Target .NET Standard 2.0 and newer only
2 participants