fix: NuGet symbols not published (#3954) #3966
Conversation
Updates the build script to handle the newer snupkg format.
| let normalPackages= | ||
| !! (outputNuGet @@ "*.nupkg") | ||
| -- (outputNuGet @@ "*.symbols.nupkg") |> Seq.sortBy(fun x -> x.ToLower()) | ||
| let normalPackages= !! (outputNuGet @@ "*.nupkg") |> Seq.sortBy(fun x -> x.ToLower()) |
There was a problem hiding this comment.
No .symbols.nupkg files are created anymore, just .nupkg and .snupkg.
| for package in normalPackages do | ||
| try | ||
| publishPackage (getBuildParamOrDefault "nugetpublishurl" "") (getBuildParam "nugetkey") 3 package | ||
| publishPackage (getBuildParamOrDefault "nugetpublishurl" "https://api.nuget.org/v3/index.json") (getBuildParam "nugetkey") 3 package |
There was a problem hiding this comment.
This one's crucial: auto pushing related snupkg files only works with the V3 API.
There was a problem hiding this comment.
Been meaning to make that change myself - we should probably also update the build-system/windows-release.yaml file too.
There was a problem hiding this comment.
Good point, PR updated
|
@aloker one last change: Is there ever a condition where we wouldn't want to try to push debug symbols? Is this check necessary any more? |
|
If auto-publishing the related snupkg files works, the check and the whole second part (publishing snupkg files) isn't necessary. I'm not sure if auto-publishing always works for private package servers or if this hardcoded for nuget.org only. I don't have a private package server at hand that's uses the V3 API. Personally I'd leave it in just in case someone publishes to a private package server and needs to push the symbols separately. |
* fix: NuGet symbols not published (akkadotnet#3954) Updates the build script to handle the newer snupkg format. * Update windows-release.yml to use V3 API of nuget.org (akkadotnet#3954)
Updates the build script to handle the newer snupkg format.
Please try and check if this works - can't test it with the official nuget packages obviously.
refs #3954