added spec to validate programmatic ActorSystem override #4473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Jun 16, 2020
| @@ -80,7 +80,7 @@ public Settings(ActorSystem system, Config config, ActorSystemSetup setup) | |||
|
|
|||
| var providerSelectionSetup = Setup.Get<BootstrapSetup>() | |||
| .FlatSelect(_ => _.ActorRefProvider) | |||
| .Select(_ => _.Identifier) | |||
| .Select(_ => _.Fqn) | |||
There was a problem hiding this comment.
Fixed a bug here - caused us not to load any ProviderSelection.Custom instances correctly
Aaronontheweb
commented
Jun 16, 2020
| internal const string RemoteActorRefProvider = "Akka.Remote.RemoteActorRefProvider, Akka.Remote"; | ||
| internal const string ClusterActorRefProvider = "Akka.Cluster.ClusterActorRefProvider, Akka.Cluster"; | ||
|
|
||
| public sealed class Local : ProviderSelection | ||
| { | ||
| private Local() : base("local", typeof(LocalActorRefProvider).FullName, false) |
There was a problem hiding this comment.
Fixed the FQN here to match the expected Akka.NET format
This was referenced Jun 17, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor PR to address a gap in testing - needed to validate that
ActorSystemSetupcan successfully override theActorRefProviderunder the covers.Added the spec to Akka.Cluster.Tests so we could override using the
ClusterActorRefProvider.