akka.PublishSubscribe - new setting and small fixes #4649
Conversation
zbynek001
changed the title
|
|
||
| Mediator.Tell(new Tools.PublishSubscribe.Internal.Status(deltaBuckets2.ToDictionary(b => b.Owner, b => b.Version), isReplyToStatus: false)); | ||
| Mediator.Tell(new Tools.PublishSubscribe.Internal.Status(versions1.SetItems(deltaBuckets2.ToImmutableDictionary(b => b.Owner, b => b.Version)), isReplyToStatus: false)); |
There was a problem hiding this comment.
this test had random behavior, depending on the order in dictionary. In some cases it lost the version info from the previous runs and returned data multiple times
There was a problem hiding this comment.
Nice fix - this one has definitely been racy in the past.
| _totalBufferSize += 1; | ||
| } | ||
|
|
||
| action(); | ||
| else |
There was a problem hiding this comment.
this is the actual fix
zbynek001
changed the title
|
|
||
| Mediator.Tell(new Tools.PublishSubscribe.Internal.Status(deltaBuckets2.ToDictionary(b => b.Owner, b => b.Version), isReplyToStatus: false)); | ||
| Mediator.Tell(new Tools.PublishSubscribe.Internal.Status(versions1.SetItems(deltaBuckets2.ToImmutableDictionary(b => b.Owner, b => b.Version)), isReplyToStatus: false)); |
There was a problem hiding this comment.
Nice fix - this one has definitely been racy in the past.
| @@ -131,13 +131,13 @@ public static Props Props(DistributedPubSubSettings settings) | |||
| /// <summary> | |||
| /// TBD | |||
| /// </summary> | |||
| public IDictionary<Address, long> OwnVersions | |||
| public IImmutableDictionary<Address, long> OwnVersions | |||
There was a problem hiding this comment.
Technically a breaking API change but not really - no one uses the actor's API directly.
| /// <exception cref="ArgumentException">TBD</exception> | ||
| public DistributedPubSubSettings(string role, RoutingLogic routingLogic, TimeSpan gossipInterval, TimeSpan removedTimeToLive, int maxDeltaElements) | ||
| public DistributedPubSubSettings( |
There was a problem hiding this comment.
Probably need to add a constructor overload here to avoid a breaking change that will have real binary compatibility impact... I'll do that in a subsequent PR
| _totalBufferSize += 1; | ||
| } | ||
|
|
||
| action(); | ||
| else |
| # The id of the dispatcher to use for DistributedPubSubMediator actors. | ||
|
|
||
| # When a message is published to a topic with no subscribers send it to the dead letters. | ||
| send-to-dead-letters-when-no-subscribers = on |
new setting
send-to-dead-letters-when-no-subscribers, some collections in messages switched to immutable, bugfix in PerGroupingBuffer