-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API for UntypedActorWithStash types #6327
Add API for UntypedActorWithStash types #6327
Conversation
d1acd40
to
d689dbe
Compare
@ismaelhamed #6325 has been merged. I can start work on backporting it probably on Friday unless you want to do it (via |
3fe7b91
to
30796a9
Compare
30796a9
to
9d233e7
Compare
I think I can find the time to do it myself. I will be backporting #6323, #6325 and #6327 if you're fine with it. |
Yes, that would delight me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the general goal behind this API change to move away from the actor creation pipeline, so the stash is provided automatically as part of the base class infrastructure itself rather than injected in from the outside?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Aaronontheweb If you think about it, using stashing is currently a little weird since users must implement an interface (including declaring the So, it is natural that these utility classes exist in the JAVA API, allowing the user to just derive from a class (like they would with normal actors) and get everything needed for stashing already set up. They can still implement the interfaces themselves if they choose to, but this is a bit of an improvement on the usability side. |
Time will tell I guess, but I see your point. |
Co-authored-by: Aaron Stannard <aaron@petabridge.com>
Added utility abstract classes for
UntypedActor
s that support stashing:UntypedActorWithStash
UntypedActorWithUnboundedStash
UntypedActorWithUnrestrictedStash
Depends on #6325
Checklist