-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copy Obsolete
attributes to Akka.Persistence.TCK
#6465
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -65,19 +66,21 @@ public void Subscribe<T>(IActorRef subscriber) | |||
Sys.EventStream.Subscribe(subscriber, typeof (T)); | |||
} | |||
|
|||
|
|||
public void Dispose() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add this back?
Hold on, I think I smelled something fishy in the code |
The old code was actually wrong, akka.net/src/contrib/testkits/Akka.TestKit.Xunit2/TestKit.cs Lines 197 to 206 in c7ac23b
|
Changes
copy
Obsolete
attributes to Akka.Persistence.TCK - same changes as we made to the TestKit base classes for Xunit.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):