Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy Obsolete attributes to Akka.Persistence.TCK #6465

Merged
merged 4 commits into from
Feb 28, 2023

Conversation

Aaronontheweb
Copy link
Member

Changes

copy Obsolete attributes to Akka.Persistence.TCK - same changes as we made to the TestKit base classes for Xunit.

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

@Aaronontheweb Aaronontheweb added this to the 1.5.0 milestone Feb 27, 2023
Copy link
Contributor

@Arkatufus Arkatufus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -65,19 +66,21 @@ public void Subscribe<T>(IActorRef subscriber)
Sys.EventStream.Subscribe(subscriber, typeof (T));
}


public void Dispose()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add this back?

@Arkatufus
Copy link
Contributor

Hold on, I think I smelled something fishy in the code

@Arkatufus
Copy link
Contributor

The old code was actually wrong, Dispose() and Dispose(bool) methods are already implemented in the base class here:

[Obsolete("Dispose(bool) is deprecated, please use DisposeAsync() instead")]
protected virtual void Dispose(bool disposing)
{
}
[Obsolete("Dispose() is obsolete, please use DisposeAsync() instead")]
public void Dispose()
{
Dispose(true);
}

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) February 28, 2023 16:58
@Aaronontheweb Aaronontheweb merged commit f0a63c5 into akkadotnet:dev Feb 28, 2023
@Aaronontheweb Aaronontheweb deleted the tck-obsolete branch February 28, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants