-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix racy FunctionRefSpecs
#7169
Fix racy FunctionRefSpecs
#7169
Conversation
@@ -204,7 +212,7 @@ public async Task FunctionRef_created_by_non_top_level_actor_must_be_watchable() | |||
|
|||
s.Tell(new GetForwarder(TestActor)); | |||
var f = await ExpectMsgAsync<FunctionRef>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this method time out - working on figuring out why. The other two calls below can also time out.
|
Welp, this was dumb - old bug in the test suite that got "fixed" when I made sure that |
FunctionRefSpecs
FunctionRefSpecs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Detailed my changes
Changes
Noticed that these were failing racily on #7168 - I'm able to reproduce the failure in Rider using "run until failure" pretty easily. Working on debugging these.
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):