Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemotePingPong: don't let permission issues crash benchmark #7241

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

Aaronontheweb
Copy link
Member

@Aaronontheweb Aaronontheweb commented Jun 8, 2024

Changes

While trying to run RemotePingPong on our Raspberry Pi units in the test lab this evening, I kept running into permissions issues due to us trying to attempt process priority elevation. Decided to do what Benchmark.NET does and just log a warning and run without elevating the priority if that's going to be an issue for the runtime.

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

@Aaronontheweb
Copy link
Member Author

Going to check to see if any of the other non-BDN benchmarks have this issue; I don't believe they do.

@Aaronontheweb
Copy link
Member Author

Attempted to elevate process priority, but failed due to Permission denied - carrying on at normal process priority.
OSVersion:                         Unix 6.8.0.76060800
ProcessorCount:                    16
ClockSpeed:                        0 MHZ
Actor Count:                       32
Messages sent/received per client: 200000  (2e5)
Is Server GC:                      True
Thread count:                      43

Num clients, Total [msg], Msgs/sec, Total [ms], Start Threads, End Threads
         1,  200000,    129450,    1545.26,            43,              69
         5, 1000000,    240732,    4154.83,            77,              89
        10, 2000000,    517331,    3866.70,            97,              97
        15, 3000000,    416899,    7196.18,           105,              97
        20, 4000000,    519077,    7706.38,           105,              97
        25, 5000000,    536769,    9315.84,           105,              89

That's what I hope to see when we run into this issue - that little warning at the top.

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) June 8, 2024 04:43
@Aaronontheweb Aaronontheweb merged commit b5a133a into akkadotnet:dev Jun 8, 2024
12 checks passed
@Aaronontheweb Aaronontheweb deleted the fix-benchmarks-linux branch June 8, 2024 05:01
@Aaronontheweb
Copy link
Member Author

Whoops, sorry about the commit email looking funny - apparently my tailscale credentials got picked up instead of my gh login. That's also why my GPG signing failed. Whoops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linux :penguin: perf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant