Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service.name attribute to metrics #1048

Merged
merged 2 commits into from
May 24, 2024

Conversation

attilakreiner
Copy link
Contributor

@attilakreiner attilakreiner commented May 23, 2024

Description

This change adds the telemetry attribute service.name to the metrics attributes in the open telemetry exporter.

Fixes #1007

Comment on lines 21 to 24
metricsAttributes:
namespace: $NAMESPACE
binding: $BINDING
service.name: zilla
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not introduce this separate metricsAttributes property and instead define service.name in attributes.

Then in otlp exporter, metrics can filter global telemetry attributes for presence of service.name and include it if present, otherwise omit.

This will let us specify the service.name and have it included in the exported metrics attributes as needed to fix the bug in the otlp demo.

Separately, @vordimous will define a story about enhancing our support for telemetry exporter attributes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfallows @attilakreiner, here is the ticket to track the additional changes to the telemetry attributes. We haven't decided if a global telemetry.attributes section is needed or if just an individual options.attributes section on each exporter will be better. The ticket includes both so that a decision can be made after some more discovery around implementation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, done, pls chk @jfallows

@attilakreiner attilakreiner changed the title Make metrics attributes configurable Add service.name attribute to metrics May 24, 2024
@attilakreiner attilakreiner marked this pull request as ready for review May 24, 2024 13:38
@jfallows jfallows merged commit 89e4088 into aklivity:develop May 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telemetry attribute service.name doesn't get sent correctly
3 participants