Prevent crashing if a metric value is None #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@M0r13n OK there seemed to be a bug in the patch.
since unlike info_collector, the label values for other collector types needed to be added as an [] and not a {}. I therefore reverted to the previous version, adding the checks as needed. Thanks much for pointing this out, obviously was an important catch. |
|
Argh, I did not see that. Thanks for fixing it! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @akpw,
it's me again. A user reported a crash that occurs if a metric value is None. This seems to have happened before, because some logic already exists that prevents such crashes. See.
I generalized this approach and patched relevant places.