Print errors using %+v #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will print extra error details(like stack traces) for errors that happen to have them
|
I can't think of an easy way to write a unit test for this so I didn't. |
|
friendly ping @akshayjshah |
Test that we're using `%+v` to print errors.
akshayjshah
approved these changes
Aug 9, 2024
|
Sorry for the long delay. The best way to test this is to add an error with a Thanks for the contribution, and for reminding me to review this PR. |
|
This is included in v1.1.0, which I just tagged. Thanks again for the contribution, @komuw! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will print extra error details(like stack traces) for errors that happen to have them
Closes: #16