First stab at docs using Github pages #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@southerneer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @charpeni and @twksos to be potential reviewers. |
|
Looks great! |
|
Maybe we could apply v4 to master and move current master to 'v3' ? |
|
Github pages could point only to master branch. I've set it now: |
|
OK cool. Yeah, I think switching v4 to master and current to v3 makes sense. Once v4 is master then Github pages will pick up docs/index.md and the site will be live. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting up this repo with Github pages would make it a lot easier to organize documentation. This PR assumes the minimal theme but can be easily modified to support any of the other themes.
If/when Github pages is ready the site would be hosted at https://asksonov.github.io/react-native-router-flux/ and we could easily link to sub-pages within the
docsfolder.I set up a quick demo of what the Github page would look like at my fork: https://southerneer.github.io/react-native-router-flux/