Added custom navbar to the project Example #2341
Conversation
|
@pgonzalez-santiago, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aksonov, @sarovin and @joenoon to be potential reviewers. |
|
Sorry, previous PR make conflicts, could you resolve it? Does Example work well with custom navbars? (If no, I should not merge but we need to fix bugs first) |
|
@pgonzalez-santiago is this something you are going to update? Otherwise I can close this PR. |
…er-flux # Conflicts: # Example/Example.js # Example/components/Launch.js
|
Done. Sorry for the delay. @mcabs3 Updated. Sorry had a lot of work and I didn't see your message. |
|
Hey @aksonov sorry I didn't answer you to "Does Example work well with custom navbars?" Custom navbar works perfectly. |
|
@pgonzalez-santiago can you pull master and make sure everything is good to go? I will then review it and get this in for you. |
|
@mcabs3 Done. |
Example/components/TabView.js
Outdated
| @@ -44,6 +44,7 @@ class TabView extends React.Component { | |||
| <Button onPress={() => { Actions.tab_4(); }}>Switch to tab4</Button> | |||
| <Button onPress={() => { Actions.tab_5({ data: 'test!' }); }}>Switch to tab5 with data</Button> | |||
| <Button onPress={() => { Actions.echo(); }}>push clone scene (EchoView)</Button> | |||
| <Button onPress={() => { Actions.echo(); }}>push clone scene (EchoView)</Button> | |||
There was a problem hiding this comment.
Duplicated line, can be removed. My mistake.
There was a problem hiding this comment.
Please, thanks! it will reduce confusion for novice react native devs.
There was a problem hiding this comment.
Do you want me to remove the line and push the changes?
|
Thanks @pgonzalez-santiago |
I have added some customs navbar in the example project just to test some stuff.