-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stat Generation update #3
Conversation
JLDesignNetwork
commented
Jan 19, 2021
- Minor modifications made on how data is output to the editor. (selections and ranges are used, to remove the original call in the editor; used for stat generation)
- Added 2 methods of stat generations.
- Added a second regular expression; used for stat matching.
- Modified the original regular expression; caused a small bug with the added functionality.
- Changed the format of the output for dice rolling. The original dice roll call is kept, and only the results are appended; not the results and roll call. Uses string formatting and dividers to maintain a clean look.
- Maintains the ability to continuously press ctrl-r for as many rolls are needed.
Sample output of the changes I have made. The stat generation methods used are those that were typical when I used to play dungeons and dragons. Also, you may notice that the images for critical success and failures are applied to all dice rolls. I included this because, again when I played, it was common to count critical success and failure for damage rolls.
|
dice-rolls_J8Uw4juq.mov |
stats_WjdEdFPJ.mov |
This is fantastic! The stat generation is a great idea and very nicely implemented with the modifiers + configuration options; so are the other improvements. I'll merge this now and then push an update to the package soon with appropriate changes to the readme and changelog noting your contribution. |