-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api,controller): adds an api/controller cabundle option to the values.yaml file #2413
Conversation
If enabled, it adds an initContainer to the api/controller deployment which mounts certs provided via either a configMap or secret. Uses an emptyDir, or optionally a pvc, for the actual certs mount within the controller (one of these is required for the controller as it needs to write to the certs folder). Signed-off-by: Leland Knight <lknite@aarr.xyz>
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fix indentation of new volumes in api server deployment Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2413 +/- ##
==========================================
+ Coverage 48.42% 48.75% +0.32%
==========================================
Files 245 250 +5
Lines 17715 17973 +258
==========================================
+ Hits 8578 8762 +184
- Misses 8719 8729 +10
- Partials 418 482 +64 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
38e88ef
to
3377d0e
Compare
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
3377d0e
to
a87148f
Compare
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
I've done some cleanup on this and tested it extensively. I have confirmed the controller's ability to communicate with git repos that have certs signed by a custom CA, which was itself self-signed. I have similarly confirmed similar for the API server's communication with OIDC identity providers. Caveat emptor: Kargo CLI and UI communicate directly with OIDC identity providers (PKCE) and therefore also need to trust the signer of an IDP's cert. This is obviously well beyond the scope of what the chart can manage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lknite thanks for getting us started on this.
If enabled, it adds an initContainer to the api/controller deployment which parses and mounts certs provided via either a configMap or secret.
The parsing step is nice as it breaks up certs which are specified in one long file into individual files before adding them.
Uses an emptyDir, or optionally a pvc, for the actual certs mount within the controller (one of these is required for the controller as it needs to write to the certs folder).
Will resolve #2271 .
This is a new pull request, previous pull request here.