Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api,controller): adds an api/controller cabundle option to the values.yaml file #2413

Merged
merged 13 commits into from
Sep 10, 2024

Conversation

lknite
Copy link
Contributor

@lknite lknite commented Aug 10, 2024

If enabled, it adds an initContainer to the api/controller deployment which parses and mounts certs provided via either a configMap or secret.

The parsing step is nice as it breaks up certs which are specified in one long file into individual files before adding them.

Uses an emptyDir, or optionally a pvc, for the actual certs mount within the controller (one of these is required for the controller as it needs to write to the certs folder).

Will resolve #2271 .

This is a new pull request, previous pull request here.

If enabled, it adds an initContainer to the api/controller deployment which mounts certs provided via either a configMap or secret.

Uses an emptyDir, or optionally a pvc, for the actual certs mount within the controller (one of these is required for the controller as it needs to write to the certs folder).

Signed-off-by: Leland Knight <lknite@aarr.xyz>
@lknite lknite requested a review from a team as a code owner August 10, 2024 20:20
Copy link

netlify bot commented Aug 10, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 3e3ff9f
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66e0868333d81100085075f0
😎 Deploy Preview https://deploy-preview-2413.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lknite lknite changed the title feat(controller,api): adds an api/controller cabundle option to the values.yaml file feat(api,controller): adds an api/controller cabundle option to the values.yaml file Aug 10, 2024
fix indentation of new volumes in api server deployment

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.75%. Comparing base (df0ab08) to head (3e3ff9f).
Report is 49 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2413      +/-   ##
==========================================
+ Coverage   48.42%   48.75%   +0.32%     
==========================================
  Files         245      250       +5     
  Lines       17715    17973     +258     
==========================================
+ Hits         8578     8762     +184     
- Misses       8719     8729      +10     
- Partials      418      482      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour krancour added this to the v0.9.0 milestone Aug 26, 2024
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour
Copy link
Member

I've done some cleanup on this and tested it extensively.

I have confirmed the controller's ability to communicate with git repos that have certs signed by a custom CA, which was itself self-signed.

I have similarly confirmed similar for the API server's communication with OIDC identity providers.

Caveat emptor: Kargo CLI and UI communicate directly with OIDC identity providers (PKCE) and therefore also need to trust the signer of an IDP's cert. This is obviously well beyond the scope of what the chart can manage.

Copy link
Member

@krancour krancour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lknite thanks for getting us started on this.

@krancour krancour added this pull request to the merge queue Sep 10, 2024
Merged via the queue into akuity:main with commit 88f7170 Sep 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants