fixed getting lookup index in a array with empty items #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added additional check for getting lookup index, because
there is the error `TypeError: Cannot read property 'foo' of null`
for arrays with empty items
eg. for `var a = [{ foo: 1 }]; a[10] = { foo: 10 }};`
- fixed tests
AleksandrZhukov
force-pushed
the
fix-getting-lookup-index
branch
from
f1a8b2b
to
9e7a4fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is the error
TypeError: Cannot read property 'foo' of nullfor arrays with empty items
eg. for
var a = [{ foo: 1 }]; a[10] = { foo: 10 }};