-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datepicker): date fns date format #1172
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case datepicker component placed after the input with datepicker directive, we can't read `this.picker.format` on first change detection run, since it's not bound yet, so we have to wait for datepicker component initialization.
@yggg the build is failing |
@yggg ping |
Codecov Report
@@ Coverage Diff @@
## master #1172 +/- ##
==========================================
- Coverage 79.85% 79.49% -0.37%
==========================================
Files 202 202
Lines 6230 6266 +36
Branches 492 503 +11
==========================================
+ Hits 4975 4981 +6
- Misses 1141 1165 +24
- Partials 114 120 +6
|
Tibing
previously approved these changes
Feb 15, 2019
Tibing
approved these changes
Feb 15, 2019
Hi @Tibing, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Closes #1056