Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): date fns date format #1172

Merged
merged 14 commits into from
Feb 15, 2019
Merged

fix(datepicker): date fns date format #1172

merged 14 commits into from
Feb 15, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Jan 22, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #1056

@yggg yggg requested review from nnixaa and Tibing January 22, 2019 07:48
@nnixaa
Copy link
Collaborator

nnixaa commented Jan 25, 2019

@yggg the build is failing
image

@nnixaa
Copy link
Collaborator

nnixaa commented Jan 30, 2019

@yggg ping

@codecov
Copy link

codecov bot commented Jan 31, 2019

Codecov Report

Merging #1172 into master will decrease coverage by 0.36%.
The diff coverage is 60.34%.

@@            Coverage Diff             @@
##           master    #1172      +/-   ##
==========================================
- Coverage   79.85%   79.49%   -0.37%     
==========================================
  Files         202      202              
  Lines        6230     6266      +36     
  Branches      492      503      +11     
==========================================
+ Hits         4975     4981       +6     
- Misses       1141     1165      +24     
- Partials      114      120       +6
Impacted Files Coverage Δ
...heme/components/datepicker/datepicker.directive.ts 61.66% <47.61%> (-11.92%) ⬇️
...heme/components/datepicker/datepicker.component.ts 80.95% <62.96%> (-4.58%) ⬇️
...amework/date-fns/services/date-fns-date.service.ts 73.68% <80%> (-3.24%) ⬇️
.../theme/components/datepicker/datepicker-adapter.ts 64.7% <0%> (-2.95%) ⬇️
...nents/calendar-kit/services/native-date.service.ts 98.52% <0%> (+1.47%) ⬆️

Tibing
Tibing previously approved these changes Feb 15, 2019
@Tibing Tibing merged commit 257eb9a into akveo:master Feb 15, 2019
@mayanksudden
Copy link

mayanksudden commented Nov 12, 2019

Hi yggg,

Validation failed with date fns date format.
I also used your above updated file date-fns-date.service.ts and datepicker.component.ts.
But there are some error on compile.
Screen-shots attached.
Could you share the specific file for this issue?
Capture
Capture_1
Capture_2

I am using below version
"@nebular/theme": "4.5.0",

@varnguyen
Copy link

Hi @Tibing,
I think the reactive form issue has not been resolved.
I am using Angular 9 and Nebular 5.0.
I have looked into the issues but have yet to find a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NbDatePicker: validation fails when using format="dd.MM.yyyy"
5 participants