Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(themes): fix typo in layout style #3098

Merged
merged 2 commits into from
Sep 28, 2022
Merged

fix(themes): fix typo in layout style #3098

merged 2 commits into from
Sep 28, 2022

Conversation

JGreenlee
Copy link
Contributor

add space on line 99

previously missing space caused themes to malfunction, if whitespace sensitive during packing

missing space caused themes to malfunction, if whitespace sensitive during packing
Copy link

@Azuka Azuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to #3100

Copy link

@krzysztof-raciniewski krzysztof-raciniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compile-error

This change fixes this error in Angular 14. Good job.

@ewalddieser
Copy link

When will this be merged? Looks like a no brainer.

@jgomesmv
Copy link

Related with #3078

Copy link

@wakonp wakonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect - will fix it

@thomaswilsonxyz thomaswilsonxyz mentioned this pull request Sep 22, 2022
@Lobaton2020
Copy link

My advice is modify the file directly while the PR is accepted to update the library version.
image
Thank you for your support guys

@sengirab
Copy link

My advice is modify the file directly while the PR is accepted to update the library version. image Thank you for your support guys

Can confirm this will work :), well, locally.. I would like deploy too ^^ this is blocking.

@sengirab
Copy link

@Tibing :)

@sengirab
Copy link

Since i don't know when this will be merged, and i need it now for a deploy, i figured out a way to get this fixed properly until this has been merged:

npm i patch-package

"scripts": {
    "postinstall": "patch-package"
}

Open up node_modules/@nebular/theme/components/layout/_layout.component.theme.scss and add a space to line :99 like this: @media screen and (min-width: $layout-window-mode-max-width + 150px) {

Now generate a patch file for "patch-package": npx patch-package @nebular/theme.

Every npm install the fix will be patched :)

Cheers!

@denStrigo denStrigo changed the title fix(themes): fix typo fix(themes): fix typo in layout style Sep 28, 2022
@denStrigo denStrigo merged commit 5740682 into akveo:master Sep 28, 2022
@flixd00
Copy link

flixd00 commented Oct 13, 2022

When will the new version including this one be available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.