Emit row data on hover. #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed method name to rowHover.
Changed mouseover emitter to rowHover.
|
This was a correction to the previous PR |
|
@vvandoorne could you resolve merge conflicts? |
|
I’ll try to resolve those now.
From: Lex Zhukov [mailto:notifications@github.com]
Sent: Wednesday, March 29, 2017 11:27 AM
To: akveo/ng2-smart-table <ng2-smart-table@noreply.github.com>
Cc: Vandoorne, Victor <VVandoorne@Biscom.com>; Mention <mention@noreply.github.com>
Subject: Re: [akveo/ng2-smart-table] Emit row data on hover. (#262)
@vvandoorne<https://github.com/vvandoorne> could you resolve merge conflicts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#262 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AZbFf5m8uJB-DUsTRDWHKZITm7pg0EyQks5rqnhPgaJpZM4MtImh>.
|
|
Resolved -- it was just a name change to the event in the tbody component which somehow git thought was a conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed the tbody emitter mouseover to rowEmitter to avoid confusion with the DOM event. Also, we needed to add an emitter to the ng2-smart-table component to "bubble up" the row to our code. We tested the code and we are able to get the row data in our components.