Release 3.20 Bogotá #2510
Merged
Release 3.20 Bogotá #2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
punchagan
commented
Jan 19, 2017
punchagan
commented
- Test plan | Unit test | Integration test
- Copyright header
- Code formatting
- Documentation
- Change log entry
…ramework_xml package
Update the branch with a recent version of develop and fix what's broken. The main fix is the removal of most of the custom pagination that was added to support Tastypie in DRF 2.3. This is replaced by two new pagination classes, LimitSizePageNumberPagination and TastypieOffsetPagination as well as a rewite of BaseRSRViewSet.paginate_queryset().
Add related models in querysets for slow DRF endpoints
A syntactically incorrect filter might result in a SyntaxError. Catch this and ignore the filter.
with request.data
to support how to create nested objects in DRF 3
[#2457]Map result type numbers to strings
Previous js code assumed this to be relative, and did URL munging which breaks now. This commit gets rid of that.
[#2475] Call FuzzyDate explicitly with an end_date Code reviewed.
AdministrativeLocation should be deletable from the project editor, by everyone who has the permissions to edit a project. Closes #2482
This fixes the problem of some `ProjectUpdate`s not having a location, since Chrome >= v50 has disabled GeoLocation API on insecure origins. Closes #2479
With the DRF 3 update, the serializers behave slightly differently -- Default values are not returned for data not passed explicitly to the serializer as initial data. This commit explicitly adds required values to the initial data.
[#2298] Fix requesting organization from UP app Code reviewed
[#2298] With the DRF3 update changes, IATI file path is absolute Code reviewed
[#2482] Add permissions for AdministrativeLocation Code reviewed
[#2484] Importing Results does not import IndicatorReferences Code reviewed
[#2479] Prompt using a different browser if geolocation disabled Code reviewed
[#2473] Test environment password dialog loses focus Code reviewed
[#2403] Clicking on Read more in project summary broken sometimes Code reviewed
[#2298] Allow updates to be posted with no photo_{caption,credit} Code reviewed
To get the list of projects where a user has `change` permissions, use DB queries instead of a loop wrapping DB queries to make the response much faster. This fixes timeouts for users who are not rsr admins but have change permissions for a lot of projects. Closes #2494
[#2494] Switch to DB queries to get allow_edit_projects Code reviewed
…bjects for typeaheads" This reverts commit e07906f. The commit was added to speed up the project editor page, a little bit, since the typeaheads were being fetched on that page. But, this change actually breaks the typeahead in the "All updates" page. The speed gain isn't critical to have, and can be done without.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.