Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1113 recall deleted user #1117

Merged
merged 8 commits into from
Feb 5, 2024
Merged

Feature/1113 recall deleted user #1117

merged 8 commits into from
Feb 5, 2024

Conversation

ifirmawan
Copy link
Contributor

@ifirmawan ifirmawan commented Feb 1, 2024 •
edited
Loading

TODO/DONE

  • Modify UserManager for implementing soft delete and restore
  • Update v1_users tests
  • Fix create user

@ifirmawan
[#1113] Implement soft delete in UserManager
b5d9830 
We can't reuseable model
```
from utils.soft_deletes_model import SoftDeletes
```
due to mistmatch column name.

SoftDeletesModel  => deleted
SystemUser => deleted_at

[#1113] Add objects_deleted, objects_with_deleted from UserManager
@ifirmawan
[#1113] Update delete user test & implementation
754fdf6
@ifirmawan ifirmawan self-assigned this Feb 1, 2024
@coveralls
Copy link

coveralls commented Feb 1, 2024 •
edited
Loading

Coverage Status

coverage: 80.971% (-0.04%) from 81.014%
when pulling 3b4202f on feature/1113-recall-deleted-user
into a054780 on develop.

@ifirmawan ifirmawan marked this pull request as ready for review February 2, 2024 07:06
@ifirmawan
Merge branch 'develop' into feature/1113-recall-deleted-user
6a9a3f7
@ifirmawan
[#1113] Implement SoftDeletes from utils.soft_deletes_model
3b4202f 
- Replace soft deletes queryset in UserManager by extending SoftDeletesManager
- Remove deleted_at in users model
@dedenbangkit dedenbangkit merged commit e7798d1 into develop Feb 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedenbangkit dedenbangkit dedenbangkit approved these changes

Assignees

@ifirmawan ifirmawan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ifirmawan @coveralls @dedenbangkit