Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1134] Save Button Bugs on Datapoint Editing #1136

Merged
merged 4 commits into from
Feb 6, 2024
Merged

[#1134] Save Button Bugs on Datapoint Editing #1136

merged 4 commits into from
Feb 6, 2024

Conversation

abhishek-p-s
Copy link
Collaborator

@abhishek-p-s abhishek-p-s commented Feb 6, 2024 •
edited
Loading

@coveralls
Copy link

Coverage Status

coverage: 80.894% (-0.06%) from 80.95%
when pulling 4ac24ad on bug/1134-save-button-bugs-on-datapoint-editing
into 4c590be on develop.

ifirmawan
ifirmawan approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@ifirmawan ifirmawan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed it by the following use cases:

  • Normal Approval workflow (add new submission and approved by approved by the level above)
  • Approval workflow that has a rejection
  • Editing the pending submission
  • Edit some data directly in the manage data

@ifirmawan ifirmawan merged commit 41cb361 into develop Feb 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifirmawan ifirmawan ifirmawan approved these changes

@dedenbangkit dedenbangkit Awaiting requested review from dedenbangkit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhishek-p-s @coveralls @ifirmawan