Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1153] Add sync button to manage form #1154

Merged
merged 42 commits into from
Feb 14, 2024

Conversation

navins94
Copy link
Contributor

@navins94 navins94 commented Feb 7, 2024


@coveralls
Copy link

coveralls commented Feb 12, 2024

Coverage Status

coverage: 81.698% (-0.02%) from 81.716%
when pulling 0b9a40e on feature/1153-download-the-JSON-file-with-queue
into 308ddf3 on develop.

app/src/components/SyncService.js Outdated Show resolved Hide resolved
app/src/components/SyncService.js Outdated Show resolved Hide resolved
app/src/pages/ManageForm.js Outdated Show resolved Hide resolved
@ifirmawan ifirmawan self-requested a review February 12, 2024 09:34
@ifirmawan ifirmawan marked this pull request as ready for review February 12, 2024 09:52
Copy link
Contributor

@ifirmawan ifirmawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO/DONE

  • Handle offline mode, for now, set the button to disabled
  • Fix the duplication forms after clicking the sync button (attached image)

@ifirmawan ifirmawan self-assigned this Feb 13, 2024
@ifirmawan ifirmawan removed their request for review February 13, 2024 09:37
@ifirmawan ifirmawan requested review from dedenbangkit and ifirmawan and removed request for ifirmawan February 13, 2024 15:32
@ifirmawan ifirmawan merged commit 02fe5dd into develop Feb 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants