Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/1152 cleanup error on fe pages #1156

Merged
merged 15 commits into from
Feb 12, 2024

Conversation

abhishek-p-s
Copy link
Collaborator

@abhishek-p-s abhishek-p-s commented Feb 7, 2024

TODO/DONE

  • Manage Data (When Expand a Datapoint): Warning: Failed prop type: The prop record.value is marked as required in EditableCell, but its value is null.
  • Warning: Each child in a list should have a unique "key" prop. Check the render method of ControlCenter.
  • IF you go to http://localhost:3000/control-center/approvals. Edit one of the datapoint, then save. The row is still yellow. Also save edit should be on the top and sticky
  • Save edit button on the top and sticky in submissions page
  • . The row is still yellow and save button not disabled in Manage data when we edit any field with the same value

@coveralls
Copy link

Coverage Status

coverage: 81.591% (+0.1%) from 81.469%
when pulling 583e93d on bug/1152-cleanup-error-on-fe-pages
into e4de57d on develop.

@ifirmawan ifirmawan merged commit e03ed44 into develop Feb 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants