Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1166 fix showing monitoring #1184

Merged
merged 7 commits into from
Feb 20, 2024
Merged

Feature/1166 fix showing monitoring #1184

merged 7 commits into from
Feb 20, 2024

Conversation

ifirmawan
Copy link
Contributor

@ifirmawan ifirmawan commented Feb 20, 2024 •
edited
Loading

TODO/DONE

  • Fix form-data endpoint in manage data
  • Fix form-data endpoint get by parent in details monitoring data
  • Add tests: tests_monitoring_endpoints

Front-end bug

  • Fix after saving updates
  • Fix pagination when changing the form
  • Remove unnecessary warning icon in datapoint name column

@ifirmawan ifirmawan self-assigned this Feb 20, 2024
@coveralls
Copy link

coveralls commented Feb 20, 2024 •
edited
Loading

Coverage Status

coverage: 78.732% (-0.03%) from 78.76%
when pulling 92c3cee on feature/1166-fix-showing-monitoring
into d3f184a on develop.

@ifirmawan ifirmawan marked this pull request as ready for review February 20, 2024 04:04
@dedenbangkit dedenbangkit merged commit 3e9a716 into develop Feb 20, 2024
2 checks passed
@dedenbangkit dedenbangkit deleted the feature/1166-fix-showing-monitoring branch February 20, 2024 05:43
@ifirmawan ifirmawan linked an issue Mar 6, 2024 that may be closed by this pull request
Monitoring List for Manage Data API #1166
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedenbangkit dedenbangkit dedenbangkit approved these changes

Assignees

@ifirmawan ifirmawan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Monitoring List for Manage Data API
3 participants
@ifirmawan @coveralls @dedenbangkit