Chore: not use non-public api #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as it is a non-public api.
g-plane
reviewed
Jun 8, 2019
| "string-similarity": "^3.0.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@not-an-aardvark/node-release-script": "^0.1.0", | ||
| "@types/eslint": "^4.16.6", | ||
| "eslint": "^5.14.0", | ||
| "eslint": "https://github.com/eslint/eslint.git", |
There was a problem hiding this comment.
这里没必要用 Git 上的代码吧？用 * 或 latest 就可以了。
There was a problem hiding this comment.
可以尽可能早的发现兼容性问题。dev deps也不会影响到用户。todo：测试与 eslint v5/v6的兼容
| @@ -0,0 +1,1359 @@ | |||
| /** | |||
There was a problem hiding this comment.
emmmm 考虑到维护成本。。感觉最好是把用到的函数复制出来就行。
|
我要merge&发布新版本了，有什么优化的建议可以新建一个pr哈~ @g-plane 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.