Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prop types for popup component #15

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Add prop types for popup component #15

merged 1 commit into from
Oct 14, 2020

Conversation

phanlyhuynh
Copy link
Contributor

@phanlyhuynh phanlyhuynh commented Oct 14, 2020 •
edited
Loading

Related issue: #9

@phanlyhuynh phanlyhuynh mentioned this pull request Oct 14, 2020
Closed
aladhims
aladhims approved these changes Oct 14, 2020
View reviewed changes
Copy link
Owner

@aladhims aladhims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 👍 @phanlyhuynh

@aladhims aladhims merged commit 02edbd3 into aladhims:master Oct 14, 2020
@aladhims aladhims mentioned this pull request Oct 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aladhims aladhims aladhims approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phanlyhuynh @aladhims