Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix correct exit code on remote/local task error #27

Merged
merged 7 commits into from
Jul 30, 2022
Merged

Conversation

alajmo
Copy link
Owner

@alajmo alajmo commented Jul 30, 2022

What's Changed

Concerns #23.

Changes:

  • If a task fails, then return the last exit code from said task iff --any-errors-fatal=true, otherwise the exit code will be 0
  • If a host is unreachable and --ignore-unreachable=false, return error code 4

There's some additional work that needs to be done before the v1.0.0 release, such as:

  • What error codes to use for:
    • Syntax issues
    • Unreachable
    • Partial error
      • situations where hosts return different exit codes (one returns exit code 4, one returns exit code 9, one returns exit code 0 for instance, what should sake show?)

but I'll do the work in a separate PR when the feature set is complete (so as not to redo work).

@alajmo alajmo merged commit f88a63a into main Jul 30, 2022
@alajmo alajmo deleted the feat/exit-code branch July 30, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant