-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(platforms): enable web platform support #194
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
==========================================
- Coverage 76.70% 76.02% -0.69%
==========================================
Files 26 26
Lines 674 684 +10
==========================================
+ Hits 517 520 +3
- Misses 157 164 +7
☔ View full report in Codecov by Sentry. |
Thanks for your contribution @levischechter! May I ask what's the difference between this and #172? I was actually waiting someone to test that before merging it |
@RiccardoM In the previous one I didn't used the right ClientChannel as the abstract class, and I didn't enabled the option to use separate hosts for the grpc and the grpcweb protocols |
Thank you so much for your contribution! 🙏 |
Description
Use
GrpcOrGrpcWebClientChannel
class fromgrpc
package so also browsers will be able to communicatewith the GrpcWeb server of cosmos-sdk based blockchains.
Closes #172
Checklist
make format
- nop.make lint
- nop.Files changed
in the Github PR explorer and added meaningful comments - nop.