Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platforms): enable web platform support #194

Merged
merged 4 commits into from
May 10, 2023
Merged

feat(platforms): enable web platform support #194

merged 4 commits into from
May 10, 2023

Conversation

levischechter
Copy link
Contributor

@levischechter levischechter commented May 8, 2023

Description

Use GrpcOrGrpcWebClientChannel class from grpc package so also browsers will be able to communicate
with the GrpcWeb server of cosmos-sdk based blockchains.

Closes #172

Checklist

  • Targeted PR against correct branch -yup.
  • #140
  • manual testing by me. tests includes android and web platforms against an cosmos-sdk based blockchain grpc and grpcweb servers respectfully.
  • Run make format - nop.
  • Run make lint - nop.
  • no need as nothing else should be made by the developer for the default behavior.
  • left it to the maintainers.
  • Re-reviewed Files changed in the Github PR explorer and added meaningful comments - nop.

@levischechter levischechter mentioned this pull request May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 17.64% and project coverage change: -0.69 ⚠️

Comparison is base (292e83a) 76.70% compared to head (454f0e5) 76.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
- Coverage   76.70%   76.02%   -0.69%     
==========================================
  Files          26       26              
  Lines         674      684      +10     
==========================================
+ Hits          517      520       +3     
- Misses        157      164       +7     
Impacted Files Coverage Δ
lib/transactions/sender/tx_sender.dart 69.23% <0.00%> (ø)
lib/transactions/signer/tx_signer.dart 75.55% <ø> (ø)
lib/wallet/network_info.dart 52.11% <18.75%> (-3.63%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@levischechter levischechter changed the title Enhance repository by enable web platform support feat(platforms): Enhance repository by enable web platform support May 8, 2023
@RiccardoM
Copy link
Contributor

Thanks for your contribution @levischechter! May I ask what's the difference between this and #172? I was actually waiting someone to test that before merging it

@levischechter
Copy link
Contributor Author

@RiccardoM In the previous one I didn't used the right ClientChannel as the abstract class, and I didn't enabled the option to use separate hosts for the grpc and the grpcweb protocols

@RiccardoM RiccardoM changed the title feat(platforms): Enhance repository by enable web platform support feat(platforms): enable web platform support May 10, 2023
@RiccardoM
Copy link
Contributor

Thank you so much for your contribution! 🙏

@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label May 10, 2023
@RiccardoM RiccardoM merged commit 0ba6784 into alan-sdk:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants