ION create operation FFI #383
Annotations
4 warnings
`if` chain can be rewritten with `match`:
trustchain-ion/src/utils.rs#L365
warning: `if` chain can be rewritten with `match`
--> trustchain-ion/src/utils.rs:365:9
|
365 | / if current_unixtime as i64 > target_unixtime {
366 | | end_height = current_height; // TODO CHECK: original script has: current_height - 1;
367 | | } else if (current_unixtime as i64) < target_unixtime {
368 | | start_height = current_height; // TODO CHECK: original script has: current_height + 1;
369 | | }
| |_________^
|
= help: consider rewriting the `if` chain to use `cmp` and `match`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_chain
= note: `#[warn(clippy::comparison_chain)]` on by default
|
use of `unwrap_or` to construct default value:
trustchain-ion/src/attestor.rs#L162
warning: use of `unwrap_or` to construct default value
--> trustchain-ion/src/attestor.rs:162:44
|
162 | &linked_data_proof_options.unwrap_or(LinkedDataProofOptions::default()),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
= note: `#[warn(clippy::unwrap_or_default)]` on by default
|
unused import: `StreamExt`:
trustchain-ion/src/utils.rs#L9
warning: unused import: `StreamExt`
--> trustchain-ion/src/utils.rs:9:15
|
9 | use futures::{StreamExt, TryStreamExt};
| ^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|