[core] Allow moving files at any point #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had many concerns about the prior approach to closing excess streams due to how it used a while loop and also async/await. To keep things simple, make MaybeRemoveOldestStreams a non-async method, so it's a bit easier to reason about what's happening. The method now chooses the stream which should be disposed, cleans up the internal state, and then queues that stream for async disposal. The engine does not have a strict limit on total open handles, and it makes no promises about *precisely* how many filehandles can be open at a given point in time, so the fact the dispose is slightly async is still fine. If someone has an actual hard limit on the exact number of file streams which can be opened, then this delay is just one of many issues they'll encounter.
This is just for tests, so if an error occurs due to disposing the http listener, just catch it and ignore it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support to move files while the torrent is actively running was added as part of #445 .
Remove the code which prevents users from being able to do this.
Partially fixes: #598