Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blockquotes aren't distinguished at all #50

Closed
xenoterracide opened this issue Mar 16, 2017 · 3 comments
Closed

blockquotes aren't distinguished at all #50

xenoterracide opened this issue Mar 16, 2017 · 3 comments
Labels
enhancement

Comments

@xenoterracide
Copy link
Contributor

xenoterracide commented Mar 16, 2017 •
edited
Loading

This post has a number of blockquotes, none of which have different formatting and so you can't tell what's being quoted. screenshot contains quoted and unquoted text.

image

image
@xenoterracide xenoterracide changed the title blockquotes are distinguished at all blockquotes aren't distinguished at all Mar 16, 2017
@alanorth
Copy link
Owner

alanorth commented Mar 16, 2017 •
edited
Loading

Ah, yes, this is unfortunate. Bootstrap's blockquote syntax requires class blockquote in order to apply styling, see this example:

screen shot 2017-03-16 at 11 50 53-fs8

So the HTML code that Hugo generates for Markdown-style blockquotes doesn't get style applied when using Bootstrap's default config.

@alanorth
Copy link
Owner

Thanks @xenoterracide. Fixed in 132d659 by applying Bootstrap's same style to all <blockquote> tags.

@xenoterracide
Copy link
Contributor Author

Thanks :D I might consider filing a bug with bootstrap too.. because I notice this is a change from 3.x, and I'm not sure that it needs to be.

@xenoterracide xenoterracide mentioned this issue Mar 16, 2017
Closed
alanorth added a commit that referenced this issue Aug 11, 2017
@alanorth
source/scss/main.scss: Apply blockquote style to all blockquotes
de19620 
Bootstrap's default only styles blockquote tags that also have the
class "blockquote". As Hugo's Markdown syntax for blockquotes only
produces bare blockquote tags, we should apply the same style to
those as well, as this is most likely what users expect.

Note: there seems to be a regression in the style used in v4 Alpha
6 as compared to v4 Beta 1. Need to follow that up, but for now I
will just copy the style verbatim.

See: #50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xenoterracide @alanorth