Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated deps and update to new updated docs #2

Merged
merged 1 commit into from
Dec 29, 2021

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Dec 20, 2021

github.com/willscott/carbs has been moved into github.com/ipld/go-car/v2/..., this also update to support contexted blockstores.

I'm using context.Background rather than forwarding a ctx through the call chain to avoid breaking this API as the rest of go-carbites isn't context aware.

github.com/willscott/carbs has been moved into 
github.com/ipld/go-car/v2/..., this also update to support contexted 
blockstores.
Copy link
Owner

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should maybe add ...WithContext suffixed constructors but this is great as is!

@alanshaw alanshaw merged commit b0cadfc into alanshaw:main Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants